josh/jsvn
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

avoid modifying array as iterating through it

Browse Source
This commit is contained in:
Josh Holtrop 2012-06-27 13:36:36 -04:00
parent 34ed003e51
commit d425d7ae14
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
jsvn
View File

@ -754,7 +754,7 @@ def lockable(argv, svn, out):
return RET_OK return RET_OK
def diff(argv, svn, out): def diff(argv, svn, out):
doing_summarize = False doing_summarize = '--summarize' in argv
for i, v in enumerate(argv): for i, v in enumerate(argv):
m = re.match('(.*?)(\.\.\.?)(.*)$', v) m = re.match('(.*?)(\.\.\.?)(.*)$', v)
if m is not None: if m is not None:
@ -775,8 +775,7 @@ def diff(argv, svn, out):
return RET_ERR return RET_ERR
url1 += '@%d' % r url1 += '@%d' % r
argv = argv[:i] + [url1, url2] + argv[i + 1:] argv = argv[:i] + [url1, url2] + argv[i + 1:]
if v == '--summarize': break
doing_summarize = True
pout = Popen([svn] + argv, stdout=PIPE).stdout pout = Popen([svn] + argv, stdout=PIPE).stdout
for line in iter(pout.readline, ''): for line in iter(pout.readline, ''):
if doing_summarize: if doing_summarize: