josh/propane
1
0
Fork 0
Code Issues 3 Pull Requests Projects Releases Wiki Activity

Fail specs on any compiler warnings in addition to errors

Browse Source
This commit is contained in:
Josh Holtrop 2026-08-20 11:12:58 -04:00
parent d466a4b024
commit cf27fefc7b
2 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
spec/propane_spec.rb
View File

@ -91,26 +91,29 @@ EOF
end end
case options[:language] case options[:language]
when "c" when "c"
command = [*%w[gcc -g -Wall -o spec/run/testparser -Ispec -Ispec/run], *parsers, *test_files, "spec/testutils.c", "-lm"] command = [*%w[gcc -g -Wall -Werror -o spec/run/testparser -Ispec -Ispec/run], *parsers, *test_files, "spec/testutils.c", "-lm"]
when "cpp" when "cpp"
command = [*%w[g++ -g -x c++ -Wall -o spec/run/testparser -Ispec -Ispec/run], *parsers, *test_files, "spec/testutils.c", "-lm"] command = [*%w[g++ -g -x c++ -Wall -Werror -o spec/run/testparser -Ispec -Ispec/run], *parsers, *test_files, "spec/testutils.c", "-lm"]
when "d" when "d"
command = [*%w[ldc2 -g --unittest -of spec/run/testparser -Ispec], *parsers, *test_files, "spec/testutils.d"] command = [*%w[ldc2 -g -w -de --unittest -of spec/run/testparser -Ispec], *parsers, *test_files, "spec/testutils.d"]
when "rust" when "rust"
# Compile each generated parser to an rlib, then compile the test crate # Compile each generated parser to an rlib, then compile the test crate
# against them. Safe Rust needs no valgrind, but it is run anyway. # against them. Safe Rust needs no valgrind, but it is run anyway.
# Both compiles deny warnings so that a warning introduced into the
# generated parser (or into a spec test file) fails the spec rather than
# scrolling past unnoticed.
externs = [] externs = []
options[:parsers].each do |name| options[:parsers].each do |name|
crate = "testparser#{name}" crate = "testparser#{name}"
rlib = "spec/run/lib#{crate}.rlib" rlib = "spec/run/lib#{crate}.rlib"
rustc = [*%w[rustc --edition 2021 --crate-type=rlib -A warnings], rustc = [*%w[rustc --edition 2021 --crate-type=rlib -D warnings],
"--crate-name", crate, "-o", rlib, "spec/run/testparser#{name}.rs"] "--crate-name", crate, "-o", rlib, "spec/run/testparser#{name}.rs"]
expect(system(*rustc)).to be_truthy expect(system(*rustc)).to be_truthy
externs += ["--extern", "#{crate}=#{rlib}"] externs += ["--extern", "#{crate}=#{rlib}"]
end end
# rustc takes a single crate root; any additional Rust test files are # rustc takes a single crate root; any additional Rust test files are
# expected to be pulled in as modules or provided by the parser crate. # expected to be pulled in as modules or provided by the parser crate.
command = [*%w[rustc --edition 2021 -A warnings -o spec/run/testparser], *externs, test_files.first] command = [*%w[rustc --edition 2021 -D warnings -o spec/run/testparser], *externs, test_files.first]
end end
result = system(*command) result = system(*command)
expect(result).to be_truthy expect(result).to be_truthy

2
spec/test_input_index.rs
View File

@ -1,7 +1,7 @@
use testparser::*; use testparser::*;
fn main() { fn main() {
let mut c = p_context_new(b"ab"); let c = p_context_new(b"ab");
assert_eq!(0, p_input_index(&c)); assert_eq!(0, p_input_index(&c));
p_context_delete(c); p_context_delete(c);